Skip to content

task_6_homework#5

Open
ArtsiomMusin wants to merge 1 commit intospajic:masterfrom
ArtsiomMusin:task_6_homework
Open

task_6_homework#5
ArtsiomMusin wants to merge 1 commit intospajic:masterfrom
ArtsiomMusin:task_6_homework

Conversation

@ArtsiomMusin
Copy link

Проведена следующая оптимизация для уменьшения размера js:

  1. chart.js вынесен в отдельный chunk.
  2. использован chart.min.js вместо chart.js
  3. убраны все locals из moment

Отчет webpack-bundle-analyzer до:
before

После:
after

После оптимизации размер бюджета не превышен.
transferSize.javascript with value 399907 limit max 460000

Сравнение slow.har & fast.har:
https://compare.sitespeed.io/?har1=https://raw.githubusercontent.com/ArtsiomMusin/task-6/task_6_homework/sitespeed-result/slow.har&har2=https://raw.githubusercontent.com/ArtsiomMusin/task-6/task_6_homework/sitespeed-result/fast.har&compare=1

Copy link
Owner

@spajic spajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

variable :ALGOLIASEARCH_API_KEY, :String, default: only_in_test
variable :ALGOLIASEARCH_APPLICATION_ID, :String, default: only_in_test
variable :ALGOLIASEARCH_SEARCH_ONLY_KEY, :String, default: only_in_test
variable :ALGOLIASEARCH_API_KEY, :String, default: '5c7ff235fb6e8f8b735904919e0d8e17'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, ключи нельзя коммитить.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants